removing unused import causing circular dependency #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsavchenko
approved these changes
Sep 3, 2024
volodymyrss
reviewed
Sep 4, 2024
volodymyrss
changed the title
volodymyrss
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Seems like this import is not used, strange that it's there. Good to remove, thanks!
Note @ferrigno that I renamed the PR to avoid just reciting the relation with issue which is already tracked by github.
Also clear title will help to understand the change in the future.
It's there from the initial implementation, which was largely refactored then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple patch seems to solve a circular import issue